-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[.NET] Add initial nullable reference types support #281
Conversation
c0519ed
to
836f5b6
Compare
nullable annotations are still disabled for: Motivation:
by this reason this is only initial support |
Important: functionally library is the same |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reviewed the DTOs created by the AstConverter against the schema for Messages and made a few comments where I found differences.
The AstConverter is a limited implementation of Cucumber.Messages. Eventually we should port this over consuming the Cucumber.Messages types directly.
@Romfos - would love to have your assistance in applying this same nullable annotations to the template that is used to generate the Io.Cucumber.Messages.Types classes.
please, during review, pay attention for all code base, not only changed files motivation:
should description be nullable here? |
hm, we have a separate library with copy-paste here? |
I'm really not sure. This part of the code base concerns the AST; I'm not knowledgable enough about that section to provide guidance. Gaspar is the expert to depend upon. |
I suspect its a result of how and when the libraries were built. They are not copy-paste, but parallel implementations of the same object model. The one you see in this library is a subset of that in the Cucumber.Messages library. |
|
Probably we need to reference them from Cucumber.Messages insted of have this non-compatible copy here |
The latest version of messages has been released. Should be available on NuGet. |
ok, then lets put on hold, until cucumber messages are not updated with NRE |
🤔 What's changed?
⚡️ What's your motivation?
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
n\a
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.